Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: add os_sync_wait_on_address and related definitions #3769

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

joboet
Copy link
Member

@joboet joboet commented Jul 9, 2024

rust-lang/rust#122408 will use some of these definitions and it seems neater to add the rest as well. Unfortunately, Apple has forgotten to upload the complete documentation to their website, here is the complete header file for everything but os_clockid_t and OS_CLOCK_MACH_ABSOLUTE_TIME.

@rustbot
Copy link
Collaborator

rustbot commented Jul 9, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@joboet

This comment was marked as resolved.

@joboet joboet force-pushed the libc-0.2 branch 2 times, most recently from bd74286 to 4c4e984 Compare July 11, 2024 11:58
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor added this pull request to the merge queue Jul 13, 2024
Merged via the queue into rust-lang:libc-0.2 with commit 043e8a3 Jul 13, 2024
53 checks passed
@tgross35 tgross35 added the main-needs-cherry-pick This PR was merged against libc-0.2 but does not yet exist in main. label Aug 13, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 29, 2024
(apply <rust-lang#3769> to `main`)
[ resolve conflicts - Trevor ]
(cherry picked from commit 5bd8143)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 29, 2024
(apply <rust-lang#3769> to `main`)
(cherry picked from commit 17cb3a2)
@tgross35 tgross35 added main-applied This PR was merged against libc-0.2 and main has since been updated to include it and removed main-needs-cherry-pick This PR was merged against libc-0.2 but does not yet exist in main. labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main-applied This PR was merged against libc-0.2 and main has since been updated to include it S-waiting-on-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants