add support for s390x #377
Conversation
| pub const POSIX_FADV_DONTNEED: ::c_int = 4; | ||
| #[cfg(targe_arch = "s390x")] | ||
| pub const POSIX_FADV_NOREUSE: ::c_int = 5; |
There was a problem hiding this comment.
Could these be pushed down and duplicated everywhere except s390x?
There was a problem hiding this comment.
I was going to do that but too tired already :-)
Holy cow, nice! Does |
Sadly, no. At least Ubuntu's doesn't. I also tried compiling QEMU 2.6 myself but that didn't work either. Both qemu-s390xs segfaulted with even the simplest cross compiled C program. I just saw QEMU 2.7 was released. I'll try that one and hope that the issue got magically fixed. |
One thing I noticed recently was that |
|
Oh, that sounds weird but I'm not that surprised. I've seen a 64-bit QEMU binary segfault whereas a 32-bit QEMU binary worked fine before. Sadly, the qemu-system-s390x package is only avaliable for the s390x architecture itself. |
Done, I think. |
add support for s390x tested by running libc-test on real s390x hardware. r? @alexcrichton
|
☀️ Test successful - status-appveyor, travis |
Added lseek and seek64 I have added lseek and seek64 to unistd, the last one targeting Linux/Android only. I wasn't sure where to place the Whence enum, or if it's a nice of doing, I am quite fresh to Rust.
tested by running libc-test on real s390x hardware.
r? @alexcrichton