Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pthread_equal #3773

Merged
merged 1 commit into from
Aug 13, 2024
Merged

add pthread_equal #3773

merged 1 commit into from
Aug 13, 2024

Conversation

joboet
Copy link
Member

@joboet joboet commented Jul 18, 2024

From its documentation:

The pthread_equal() function is necessary because thread IDs should be considered opaque: there is no portable way for applications to directly compare two pthread_t values.

@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@tgross35
Copy link
Contributor

Can you change this to target main? Can cherry pick to stable after merge.

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 12, 2024
@joboet joboet changed the base branch from libc-0.2 to main August 12, 2024 22:08
@bors
Copy link
Contributor

bors commented Aug 12, 2024

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35
Copy link
Contributor

tgross35 commented Aug 12, 2024

I don't know why freebsd would have failed, it should be available https://man.freebsd.org/cgi/man.cgi?query=pthread_equal&sektion=3.

edit: looks like maybe it was something spurious or just had the outdated CI job. Will try with this rebase.

@tgross35 tgross35 added this pull request to the merge queue Aug 13, 2024
Merged via the queue into rust-lang:main with commit 07509d7 Aug 13, 2024
39 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 16, 2024
(backport <rust-lang#3773>)
(cherry picked from commit 83b3393)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants