-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define SO_BINDTOIFINDEX on Fuchsia #3784
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
I assume the failed CI check for macOS is a flake? I don't think this change would have impacted macOS 🤷 |
not at all :) |
Please elaborate - does "not at all" refer to the failure being a flake, or are you saying I'm incorrect and that this does indicate my change impacts macOS? |
no I meant your change has nothing to do with the macos failure |
Forgive me if I'm wrong, but from browsing the other PR discussions it looks like I don't have a way to get the mac CI to rerun other than asking @JohnTitor to kick it off. |
Fuchsia supports SO_BINDTOIFINDEX as of API level 20: https://cs.opensource.google/fuchsia/fuchsia/+/main:sdk/lib/zxio/socket.cc;l=755;drc=b03121152bf13fb8898a95b58d952c95ee73cd0c
@rustbot label +stable-nominated |
Fuchsia supports SO_BINDTOIFINDEX as of API level 20: https://cs.opensource.google/fuchsia/fuchsia/+/main:sdk/lib/zxio/socket.cc;l=755;drc=b03121152bf13fb8898a95b58d952c95ee73cd0c (backport <rust-lang#3784>) (cherry picked from commit 09b8a4f)
Fuchsia supports SO_BINDTOIFINDEX as of API level 20: https://cs.opensource.google/fuchsia/fuchsia/+/main:sdk/lib/zxio/socket.cc;l=755;drc=b03121152bf13fb8898a95b58d952c95ee73cd0c