Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port for RTEMS #3866

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Add port for RTEMS #3866

merged 1 commit into from
Sep 17, 2024

Conversation

thesummer
Copy link
Contributor

@thesummer thesummer commented Aug 23, 2024

This is a port to the main branch of PR #3561.

I am currently porting the rust compiler and stdlib to the RTEMS realtime operating system (https://www.rtems.org/).
See #3561 for reference.
Once this is merged the attached changes also need to be added to libc to provide the target platform support.

The main resources for this port were:

@rustbot
Copy link
Collaborator

rustbot commented Aug 23, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@tgross35
Copy link
Contributor

Thanks! I'll take a look at this once rust-lang/rust#127021 is available on a nightly.

@bors
Copy link
Contributor

bors commented Aug 29, 2024

☔ The latest upstream changes (presumably #3872) made this pull request unmergeable. Please resolve the merge conflicts.

@tgross35
Copy link
Contributor

tgross35 commented Sep 3, 2024

That rust-lang/rust PR should merge soon, but until then

@rustbot blocked

@thesummer
Copy link
Contributor Author

@tgross35 I rebased to current main.

@rustbot review

@tgross35
Copy link
Contributor

I didn't take too close of a look at everything, but assuming tests pass this should be fine to get started. Thanks!

@tgross35 tgross35 added this pull request to the merge queue Sep 17, 2024
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Sep 17, 2024
@thesummer
Copy link
Contributor Author

thesummer commented Sep 17, 2024

Thanks, I took a look at existing ports and updated the missing values for types from newlib or RTEMS sources. I guess we will find some errors along the way once we test the port more thorougly with the nightly compiler.

Merged via the queue into rust-lang:main with commit cee3e05 Sep 17, 2024
41 checks passed
@bors bors mentioned this pull request Sep 17, 2024
@thesummer
Copy link
Contributor Author

thesummer commented Sep 27, 2024

@tgross35 Sorry, I was a bit pre-occupied the last week and lost a bit track of the status here. Is there anything else I can help you with?

Edit: Commented the wrong PR. Meant to comment here: #3932 (comment) 🙈

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
(backport <rust-lang#3866>)
(cherry picked from commit 6a78b02)
@tgross35 tgross35 mentioned this pull request Oct 15, 2024
@tgross35 tgross35 removed the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 15, 2024
@tgross35 tgross35 added the stable-applied This PR has been cherry-picked to libc's stable release branch label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants