Handle version output correctly when clippy-driver used
#3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-bennett
force-pushed
the
clippy-rustc-wrapper
branch
from
0553e37
to
18b8da9
Compare
nathaniel-bennett
changed the title
clippy-driver when used for RUSTC_WRAPPERclippy-driver used
tgross35
approved these changes
Sep 1, 2024
tgross35
added
the
stable-nominated
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 6, 2024
Change `if let` to a `match` because it is about equal complexity. This should allow backporting [1] easier. Additionally, add some new documentation comments. [1]: rust-lang#3893
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 6, 2024
This is a combined cherry-pick of the following two commits: - 18b8da9 ("Handle rustc version output correctly...") - d61f6f6 ("Update `rustc_version_cmd`") These two commits are squashed for the backport to slightly reduce the amount of conflict resolution needed going forward (some small tweaks were still needed). This backports the following: - <rust-lang#3893> - <rust-lang#3903> Handle rustc version output correctly when `clippy-driver` used Update `rustc_version_cmd` Change `if let` to a `match` because it is about equal complexity. This should allow backporting [1] easier. Additionally, add some new documentation comments. [1]: rust-lang#3893
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 6, 2024
Change `if let` to a `match` because it is about the same complexity but also works with our MSRV for 0.2. This should allow backporting [1] easier, as well as future backports that touch this code. Additionally, add some new documentation comments. [1]: rust-lang#3893
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 6, 2024
This is a combined cherry-pick of the following two commits: - 18b8da9 ("Handle rustc version output correctly...") - cdf12d2 ("Update `rustc_version_cmd`") These two commits are squashed for the backport to slightly reduce the amount of conflict resolution needed going forward (some small tweaks were still needed). This backports the following: - <rust-lang#3893> - <rust-lang#3903> Commit 1 original message: Handle rustc version output correctly when `clippy-driver` used Commit 2 original message: Update `rustc_version_cmd` Change `if let` to a `match` because it is about the same complexity but also works with our MSRV for 0.2. This should allow backporting [1] easier, as well as future backports that touch this code. Additionally, add some new documentation comments. [1]: rust-lang#3893
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 6, 2024
This is a combined cherry-pick of the following two commits: - 18b8da9 ("Handle rustc version output correctly...") - cdf12d2 ("Update `rustc_version_cmd`") These two commits are squashed for the backport to slightly reduce the amount of conflict resolution needed going forward (some small tweaks were still needed). This backports the following: - <rust-lang#3893> - <rust-lang#3903> Commit 1 original message: Handle rustc version output correctly when `clippy-driver` used Commit 2 original message: Update `rustc_version_cmd` Change `if let` to a `match` because it is about the same complexity but also works with our MSRV for 0.2. This should allow backporting [1] easier, as well as future backports that touch this code. Additionally, add some new documentation comments. [1]: rust-lang#3893 Co-authored-by: Nathaniel Bennett <me@nathanielbennett.com> Co-authored-by: Trevor Gross <tmgross@umich.edu>
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 10, 2024
This is a combined cherry-pick of the following two commits: - 18b8da9 ("Handle rustc version output correctly...") - cdf12d2 ("Update `rustc_version_cmd`") These two commits are squashed for the backport to slightly reduce the amount of conflict resolution needed going forward (some small tweaks were still needed). This backports the following: - <rust-lang#3893> - <rust-lang#3903> Commit 1 original message: Handle rustc version output correctly when `clippy-driver` used Commit 2 original message: Update `rustc_version_cmd` Change `if let` to a `match` because it is about the same complexity but also works with our MSRV for 0.2. This should allow backporting [1] easier, as well as future backports that touch this code. Additionally, add some new documentation comments. [1]: rust-lang#3893 Co-authored-by: Nathaniel Bennett <me@nathanielbennett.com> Co-authored-by: Trevor Gross <tmgross@umich.edu>
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks to see if the output of
$RUSTC --versionis actually aclippy-driverversion. If so, reruns with the appropriate flags to correctly output the rust version fromclippy-driver.Resolves #1544.