Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcntl add F_TRANSFEREXTENTS for macos. #3925

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fcntl add F_TRANSFEREXTENTS for macos. #3925

merged 1 commit into from
Oct 15, 2024
+2 −0

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Sep 14, 2024 •
edited
Loading

ref

@rustbot
Copy link
Collaborator

rustbot commented Sep 14, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@devnexen
Copy link
Contributor Author

@rustbot label stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Sep 14, 2024
@devnexen devnexen mentioned this pull request Sep 14, 2024
Closed
tgross35
tgross35 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you add links to the headers in the PR description?

@devnexen devnexen force-pushed the ftransferextents_macos branch from 279c5c3 to 90a1ce7 Compare September 30, 2024 17:13
@tgross35
Copy link
Contributor

Please try to link both the headers and manpages in the future, if applicable, so I have something to check against. Found at https://newosxbook.com/src.jl?tree=xnu&file=bsd/sys/fcntl.h, lgtm.

@tgross35 tgross35 force-pushed the ftransferextents_macos branch from 90a1ce7 to 2fcf54b Compare October 15, 2024 02:40
@tgross35 tgross35 enabled auto-merge October 15, 2024 02:41
@tgross35 tgross35 added this pull request to the merge queue Oct 15, 2024
Merged via the queue into rust-lang:main with commit f6945f7 Oct 15, 2024
40 of 41 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 16, 2024
@devnexen @tgross35
fcntl add F_TRANSFEREXTENTS for macos.
cbad5be 
[ref](https://newosxbook.com/src.jl?tree=xnu&file=/bsd/man/man2/fcntl.2)

(backport <rust-lang#3925>)
(cherry picked from commit 2fcf54b)
@tgross35 tgross35 mentioned this pull request Oct 16, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devnexen @rustbot @tgross35