Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTEMS export arc4random #3989

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

thesummer
Copy link
Contributor

Description

Export ´arc4random_buf´ for RTEMS.
Seems to be preferred to the getentropy method (see here: rust-lang/rust#131774).

Sources

https://docs.rtems.org/branches/master/bsp-howto/getentropy.html

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@thesummer
Copy link
Contributor Author

r? @tgross35 This is a small follow-up we figured out here rust-lang/rust#131774, but since we can do with the work-around in the rust repo it doesn't have high priority.

@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2024

Could not assign reviewer from: tgross35.
User(s) tgross35 are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough!

@tgross35 tgross35 added this pull request to the merge queue Oct 24, 2024
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 24, 2024
Merged via the queue into rust-lang:main with commit 93dbb12 Oct 24, 2024
40 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 6, 2024
(backport <rust-lang#3989>)
(cherry picked from commit c096cdb)
@tgross35 tgross35 mentioned this pull request Nov 6, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants