Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

illumos: add syncfs #3990

Merged
merged 1 commit into from
Oct 24, 2024
Merged

illumos: add syncfs #3990

merged 1 commit into from
Oct 24, 2024

Conversation

devnexen
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2024

Some changes occurred in solarish module

cc @jclulow, @pfmooney

@devnexen
Copy link
Contributor Author

@rustbot label stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 19, 2024
tgross35
tgross35 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, I'll wait for one of the Solaris members tou double check.

@pfmooney
Copy link
Contributor

Looks fine to me, I'll wait for one of the Solaris members tou double check.

Look fine to me on the illumos side.

@tgross35 tgross35 added this pull request to the merge queue Oct 24, 2024
Merged via the queue into rust-lang:main with commit fc2e270 Oct 24, 2024
41 checks passed
@bors bors mentioned this pull request Oct 24, 2024
Merged
@tgross35 tgross35 changed the title illumos adding syncfs. illumos: add syncfs Nov 6, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 6, 2024
@devnexen @tgross35
illumos: add syncfs
8ca43c6 
https://raw.githubusercontent.com/illumos/illumos-gate/05ce3950cb6a645887911ba82ec91e3c06c5ad7c/usr/src/man/man3c/syncfs.3c

[ reworded title slightly - Trevor ]
(backport <rust-lang#3990>)
(cherry picked from commit d18863d)
@tgross35 tgross35 mentioned this pull request Nov 6, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 6, 2024
@shadow3aaa shadow3aaa mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devnexen @rustbot @pfmooney @tgross35