-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't pass -lc to Emscripten, it breaks #4002
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Thanks @tgross35! Can this get a backport? It's blocking for rust-lang/rust#131736, so it would be convenient to have a released version with this change that I can use sometime soon if possible. |
Yes this will be backported (it already has the nomination). Usually I do backports and a release once every few weeks, the next one will be pretty soon. |
See: emscripten-core/emscripten#22742 emscripten-core/emscripten#16680 rust-lang/rust#98155 rust-lang/rust#98303 rust-lang/rust#131885 (backport <rust-lang#4002>) (cherry picked from commit 66e3665)
Before this patch,
fails with:
There are quite a few other sets of linker arguments that trigger this problem, but this is the shortest. Applying this patch to rust-libc and overriding the version of libc used in
library/Crates.toml
to use the patched version, I have verified locally that the crash goes away.See:
emscripten-core/emscripten#22742
emscripten-core/emscripten#16680
rust-lang/rust#98155
rust-lang/rust#98303
rust-lang/rust#131885
cc @workingjubilee @sbc100