[0.2] Drop the libc_const_extern_fn conditional
#4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
|
☔ The latest upstream changes (presumably #4076) made this pull request unmergeable. Please resolve the merge conflicts. |
tgross35
force-pushed
the
remove-cfg-const-extern-fn
branch
2 times, most recently
from
0c726f6 to
fa7e411
Compare
Additionally deprecate the `const-extern-fn` feature. This is possible since the MSRV was increased to 1.63.
tgross35
force-pushed
the
remove-cfg-const-extern-fn
branch
from
fa7e411 to
674cc1f
Compare
tgross35
added
the
main-needs-cherry-pick
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 18, 2024
Additionally deprecate the `const-extern-fn` feature. This is possible since the MSRV was increased to 1.63. (apply <rust-lang#4063> to `main`) (cherry picked from commit 674cc1f)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 18, 2024
Additionally deprecate the `const-extern-fn` feature. This is possible since the MSRV was increased to 1.63. (apply <rust-lang#4063> to `main`) (cherry picked from commit 674cc1f)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 18, 2024
Additionally deprecate the `const-extern-fn` feature. This is possible since the MSRV was increased to 1.63. (apply <rust-lang#4063> to `main`) (cherry picked from commit 674cc1f)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 18, 2024
Additionally deprecate the `const-extern-fn` feature. This is possible since the MSRV was increased to 1.63. (apply <rust-lang#4063> to `main`) (cherry picked from commit 674cc1f) With the cherry pick, remove `const-extern-fn` rather than just deprecating it.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 18, 2024
Additionally deprecate the `const-extern-fn` feature. This is possible since the MSRV was increased to 1.63. (apply <rust-lang#4063> to `main`) (cherry picked from commit 674cc1f) With the cherry pick, remove `const-extern-fn` rather than just deprecating it.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 18, 2024
Additionally deprecate the `const-extern-fn` feature. This is possible since the MSRV was increased to 1.63. (apply <rust-lang#4063> to `main`) (cherry picked from commit 674cc1f)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 18, 2024
Additionally deprecate the `const-extern-fn` feature. This is possible since the MSRV was increased to 1.63. (apply <rust-lang#4063> to `main`) (cherry picked from commit 674cc1f)
|
Hi, Looks like this is not working? See Nix PR nix-rust/nix#2544, we tried using the git version of libc, then found that the |
|
Indeed, that was reported in #4115. Will try to fix it soon (I think I want to just remove the feature and instead use an environment variable to indicate we need ctest hacks) |
|
Update: Just realized that I can subscribe to #4115 😄 |
tgross35
added
main-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally deprecate the
const-extern-fnfeature. This is possible since the MSRV was increased to 1.63.