Make stdbuild a cargo feature #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo.toml
Outdated
| @@ -18,8 +18,8 @@ travis-ci = { repository = "rust-lang/libc" } | |||
| appveyor = { repository = "rust-lang-libs/libc" } | |||
|
|
|||
| [features] | |||
| default = ["use_std"] | |||
There was a problem hiding this comment.
This was intentionally set up like this before (enabling std as a feaeture), could this be reverted?
There was a problem hiding this comment.
Sure. It's a bit more awkward because this setup allows stdbuild to depend on no_std, which can't be done in reverse, that's all.
|
This is green now, with the changes you requested. |
Cargo.toml
Outdated
| @@ -20,6 +20,7 @@ appveyor = { repository = "rust-lang-libs/libc" } | |||
| [features] | |||
| default = ["use_std"] | |||
| use_std = [] | |||
| stdbuild = [] | |||
There was a problem hiding this comment.
Can this be avoided in this Cargo.toml? Ideally this isn't exported as part of the public API
|
I suppose, but won't that mean we can never get rid of the shim in rustc?
Anyway, done.
…On Sep 12, 2017 00:11, "Alex Crichton" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Cargo.toml
<#764 (comment)>:
> @@ -20,6 +20,7 @@ appveyor = { repository = "rust-lang-libs/libc" }
[features]
default = ["use_std"]
use_std = []
+stdbuild = []
Can this be avoided in this Cargo.toml? Ideally this isn't exported as
part of the public API
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#764 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABdsPKuRnmWoqQxh7fleK3FOwVqMOI11ks5shgR2gaJpZM4PT93Q>
.
|
|
@bors: r+ AFAIK we have no path forward for using the libc crate as-is in rustbuild, we've got a long way to go to enable that. |
|
📌 Commit 8a7069f has been approved by |
bors
added a commit
that referenced
this pull request
Sep 12, 2017
Make stdbuild a cargo feature Also invert the default feature / no std arrangement. The default still uses std, but no_std now requires opt-in instead of opt-out. This is work toward removing the shim in rustc.
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 16, 2017
{compiler-builtins,libc} shim cleanup
~~Depends on rust-lang/libc#764; opening early for feedback.~~ r? @alexcrichton
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 16, 2017
{compiler-builtins,libc} shim cleanup
~~Depends on rust-lang/libc#764; opening early for feedback.~~ r? @alexcrichton
TimNN
added a commit
to TimNN/rust
that referenced
this pull request
Sep 17, 2017
{compiler-builtins,libc} shim cleanup
~~Depends on rust-lang/libc#764; opening early for feedback.~~ r? @alexcrichton
TimNN
added a commit
to TimNN/rust
that referenced
this pull request
Sep 17, 2017
{compiler-builtins,libc} shim cleanup
~~Depends on rust-lang/libc#764; opening early for feedback.~~ r? @alexcrichton
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Oct 7, 2017
{compiler-builtins,libc} shim cleanup
~~Depends on rust-lang/libc#764; opening early for feedback.~~ r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also invert the default feature / no std arrangement. The default
still uses std, but no_std now requires opt-in instead of opt-out.
This is work toward removing the shim in rustc.