Update to new to/from_bytes functions #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbu-
reviewed
Aug 24, 2018
shared/src/lib.rs
Outdated
| @@ -12,7 +12,7 @@ lazy_static! { | |||
| .map(|chunk| { | |||
| let mut buf = [0; 4]; | |||
| buf.copy_from_slice(chunk); | |||
| f32::from_bits(u32::from_le(u32::from_bytes(buf))) | |||
| f32::from_bits(u32::from_le(u32::from_ne_bytes(buf))) | |||
There was a problem hiding this comment.
There's the function u32::from_le_bytes which is exactly the combination of u32::from_le and u32::from_ne_bytes. :)
There was a problem hiding this comment.
@tbu- indeed, I just did a find&replace. Fixed now.
|
Thanks for the PR and sorry for the delay, but this has been updated on master now so I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to rust-lang/rust#51919,
to/from_byteshas been renamed toto/from_ne_bytes. This pull request renames all occurrences to be in line with that.Additionally, I changed the newlib generator to give a helpful error message when it's missing
qemu-arm.