Ensure more functions do not panic #265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
#[cfg_attr(all(test, assert_no_panic), no_panic::no_panic)]
to more functionsexp10
andexp10f
This leaves
frexp
andfrexpf
as the only remaining functions that can panic (wasn't able to figure out how to fix).Edit: it looks like
j1f
(and possiblyj1
can also panic)Edit 2: Not sure why, but it looks like the tests didn't catch integer division in
lgamma_r
/lgammaf_r