Skip to content

Commit

Permalink
Say why it occasionally makes sense to force RVV off
Browse files Browse the repository at this point in the history
This is adapted from the comment on the feature that was added
under the design that was previously explored. This way, the
description will be present somewhere, even though it may be less
discoverable here in `cmake.rs` than it would be in manifests.
  • Loading branch information
EliahKagan committed Sep 22, 2024
1 parent dbbe477 commit 66df3f5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions zng/cmake.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ pub fn build_zlib_ng(target: &str, compat: bool) {
{
Some("OFF" | "NO" | "FALSE" | "0") => {
// Force RVV off. This turns off RVV entirely, as well as the runtime check for it.
// This is not usually necessary, but can be useful for building binaries portable
// to systems that do not support RVV but where auto-detection fails to identify
// this (as in https://github.com/zlib-ng/zlib-ng/issues/1705).
cmake.define("WITH_RVV", "OFF");
}
Some("ON" | "YES" | "TRUE" | "1") => {
Expand Down

0 comments on commit 66df3f5

Please sign in to comment.