-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize RISCV_WITH_RVV
env var on RISC-V to set WITH_RVV
cmake var
#218
Merged
+21
−0
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3a1ea59
Basic idea for `rvv-off` feature
EliahKagan d76bc6d
Also recognize an environment variable
EliahKagan 377b942
Document that `rvv-off` feature is experimental and needs `cmake`
EliahKagan a8c813e
Document `RVV_OFF` environment variable in `rvv-off` comments
EliahKagan 7579d46
Remove `rvv-off` feature
EliahKagan dbbe477
Use `RISCV_WITH_RVV` as the env var, taking ON/OFF values
EliahKagan 66df3f5
Say why it occasionally makes sense to force RVV off
EliahKagan 8636464
Fix up the environment variable string conversion
EliahKagan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I prefer "positive" features over "negative" features. By this I mean that the feature sounds like it adds something rather than taking something away.
For example, you could name the environment variable
WITH_RVV
and allowing the valuesON
andOFF
. This would be familiar to someone who knows thezlib-ng
build. It would allow forcing the use of RVV if there was ever a case where it was disabled.You could name the feature
with-rvv
. However this would require the default to compile without RVV. This has the advantage of working in more places, at the cost of behaving differently to the default behavior ofzlib-ng
.