Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ohos: Link shared lib on OpenHarmony #221

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

jschwe
Copy link
Contributor

@jschwe jschwe commented Oct 2, 2024

The OpenHarmony SDK / sysroot contains libz.so and similar to android we can assume that libz will always be available,
since the OpenHarmony zlib documentation exists and explicitly mentions linking against libz.so.

OpenHarmony is supported as a tier 2 target in rustc as *-linux-ohos

@jschwe jschwe changed the title ohos: Linked shared lib on OpenHarmony ohos: Link shared lib on OpenHarmony Oct 2, 2024
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

Once the requested change is made, I will merge.

Thank you.

build.rs Outdated Show resolved Hide resolved
The OpenHarmony SDK / sysroot contains libz.so
and similar to android we can assume that libz
will always be available.
@Byron Byron merged commit 5488e3c into rust-lang:main Oct 3, 2024
48 checks passed
@jschwe jschwe deleted the ohos_shared_lib branch October 3, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants