Cherry-pick "[MC][AsmParser] Diagnose improperly nested .cfi frames" #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This showed up when simplifying some large testcase, where the cfi directives became out of sync with the proc's they enclose. Now restricted to platforms that support .subsections_via_symbols. This reverts commit 797b68c. Fixes: llvm#72802 Differential revision: https://reviews.llvm.org/D153167 rdar://111459507
|
I'm confused. It looks like this adds an extra error, how can this fix a build failure? |
|
Closing in favor of #162. |
vext01
added a commit
to vext01/llvm-project
that referenced
this pull request
May 20, 2024
Ignore `exact` keywords for binary operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of d506aa4. This fixes llvm#72802, which manifests in the Rust build as failure to build compiler_builtins when targeting macos in some configurations.