Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport [ADT] Add <cstdint> to SmallVector (#101761) #176

Closed

Conversation

matoro
Copy link

@matoro matoro commented Aug 7, 2024

Downstream bug: https://bugs.gentoo.org/937525

Fixes build with gcc-15. CC @thesamesam

Author: Sam James <sam@gentoo.org>
Date:   Fri Aug 2 23:07:21 2024 +0100

    [ADT] Add `<cstdint>` to SmallVector (#101761)
    
    SmallVector uses `uint32_t`, `uint64_t` without including `<cstdint>`
    which fails to build w/ GCC 15 after a change in libstdc++ [0]
    
    [0] https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=3a817a4a5a6d94da9127af3be9f84a74e3076ee2

 llvm/include/llvm/ADT/SmallVector.h | 1 +
 1 file changed, 1 insertion(+)

SmallVector uses `uint32_t`, `uint64_t` without including `<cstdint>`
which fails to build w/ GCC 15 after a change in libstdc++ [0]

[0] https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=3a817a4a5a6d94da9127af3be9f84a74e3076ee2
@DianQK
Copy link
Member

DianQK commented Aug 7, 2024

Please wait for the upstream update.

@DianQK
Copy link
Member

DianQK commented Aug 13, 2024

Based on rust-lang/rustc-dev-guide#2039, I'm going to close this PR. If you need this code merged soon, please resubmit a new PR following rust-lang/rustc-dev-guide#2039. I'll also consider updating it at the next RC version. :)

@DianQK DianQK closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants