Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note to avoid setting max levels #311

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Add a note to avoid setting max levels #311

merged 1 commit into from
Jan 2, 2019

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Jan 1, 2019

For #309

Adds a note to the crate docs to discourage libraries from using the max level features.

@sfackler does this look ok to you?

@KodrAus KodrAus merged commit 3333c03 into rust-lang:master Jan 2, 2019
@KodrAus KodrAus deleted the doc/max-level-features branch January 2, 2019 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfackler sfackler sfackler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KodrAus @sfackler