Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of filter regexps. #69

Merged
merged 2 commits into from
Jan 28, 2016
Merged

Conversation

psii
Copy link

@psii psii commented Jan 12, 2016

Regexps in RUST_LOG as explained in the module documentation should
only allow log messages that match the given expression and not the
other way around.

Regexps in RUST_LOG as explained in the module documentation should
only allow log messages that match the given expression and not the
other way around.
@alexcrichton
Copy link
Member

Can you be sure to add a test for this as well? It seems odd that this wasn't tested before...

@psii
Copy link
Author

psii commented Jan 12, 2016

I attempted to write a test case before submitting this pull request, but I
didn't see a straightforward way to do this. Some restructuring of the code
is necessary. I can look for a solution but it will take some time.

2016-01-12 17:49 GMT+01:00 Alex Crichton notifications@github.com:

Can you be sure to add a test for this as well? It seems odd that this
wasn't tested before...


Reply to this email directly or view it on GitHub
#69 (comment).

@alexcrichton
Copy link
Member

One way to do this is to add an integration test under tests/foo.rs, disable the test harness, and then have the test re-execute itself with an environment variable set. That way it can test the stdout/stderr.

@psii
Copy link
Author

psii commented Jan 28, 2016

Added a test case which is implemented like you suggested.

@alexcrichton
Copy link
Member

Thanks!

alexcrichton added a commit that referenced this pull request Jan 28, 2016
Fixed handling of filter regexps.
@alexcrichton alexcrichton merged commit 44ed095 into rust-lang:master Jan 28, 2016
EFanZh pushed a commit to EFanZh/log that referenced this pull request Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants