Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple minor tweaks to stuff from use_std PR #71

Merged
merged 3 commits into from
Jan 16, 2016

Conversation

sfackler
Copy link
Member

Ok(unsafe { LOGGER.unwrap() })
unsafe {
let logger = LOGGER;
LOGGER = &NopLogger;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reset LOGGER here for slightly better hygiene and to avoid providing a permanent root for the pointer that might make Valgrind miss a memory leak.

@sfackler sfackler mentioned this pull request Jan 16, 2016
alexcrichton added a commit that referenced this pull request Jan 16, 2016
Couple minor tweaks to stuff from use_std PR
@alexcrichton alexcrichton merged commit 3cebcbf into rust-lang:master Jan 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants