Merge pull request #1651 from notriddle/notriddle/theme-switcher-js

Only switch to themes on buttons that have the `theme` class
rust-lang · Sep 17, 2021 · 601ebc5 · 601ebc5
2 parents 93008cf + 4251d7a
commit 601ebc5
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/theme/book.js b/src/theme/book.js
@@ -371,7 +371,14 @@ function playground_text(playground) {
     });
 
     themePopup.addEventListener('click', function (e) {
-        var theme = e.target.id || e.target.parentElement.id;
+        var theme;
+        if (e.target.className === "theme") {
+            theme = e.target.id;
+        } else if (e.target.parentElement.className === "theme") {
+            theme = e.target.parentElement.id;
+        } else {
+            return;
+        }
         set_theme(theme);
     });