Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stylesheet contrast issues #1442

Closed
endgame opened this issue Jan 13, 2021 · 4 comments · Fixed by #1470
Closed

Stylesheet contrast issues #1442

endgame opened this issue Jan 13, 2021 · 4 comments · Fixed by #1470

Comments

@endgame
Copy link

endgame commented Jan 13, 2021

Some of the styling is quite low-contrast, which makes it harder to read and navigate than it could be:

  • The <h1> of the currently-viewed page is light-on-light,
  • I didn't notice the < and > previous/next page controls for a couple of minutes because they render light-on-light,
  • Inline code (where syntax highlighting is not applied) is dark-on-dark.

I'm no designer so I hesitate to suggest specific fixes, but https://contrastchecker.com/ is good at least to check body text.

(Re-reporting scrive/nix-workshop#1 upstream.)
@ehuss
Copy link
Contributor

ehuss commented Jan 13, 2021

Can you check out #1353 and see if those color adjustments help?

@endgame endgame mentioned this issue Jan 13, 2021
Closed
@endgame
Copy link
Author

endgame commented Jan 13, 2021

Yes, the "contrast" theme is a massive improvement.

@tim-seoss
Copy link
Contributor

Glad you've found that useful - any critical feedback on that theme is also welcome of course!

@tim-seoss
Copy link
Contributor

I'd be interested to hear others' thoughts on:

  • Is contrast a good name for the new theme?
  • Would a revised version of the PR, which instead implements the new theme in the light theme be preferable (or not!)? If "yes", then the existing light colour palette could either be removed, or renamed to something like soft?
  • Any aesthetic suggestions?

Thanks!

tim-seoss added a commit to tim-seoss/mdBook that referenced this issue Feb 21, 2021
@tim-seoss
Enhance text contrast of light theme to improve accessibility.
7f59fdd 
The existing light theme has relatively low contrast between the text
(and other UI elements) and background (especially within code blocks).
This presents difficulties for people with reduced visual contrast
perception (common in older adults).

This patch makes changes to the default `light` theme to meet the
minimum contrast requirement of the v2.1 W3C WCAG (Web Content
Accessibility Guidelines)
https://www.w3.org/WAI/WCAG21/quickref/#contrast-minimum

The small size, and slender font used for the title text makes it hard
to read, even with the increased contrast colour scheme, so this patch
also increases the size of the title text font by 20%.

Closes rust-lang#1442
@tim-seoss tim-seoss mentioned this issue Feb 21, 2021
Merged
notriddle pushed a commit to notriddle/mdBook that referenced this issue Dec 23, 2021
@tim-seoss @notriddle
Enhance text contrast of light theme to improve accessibility.
1865e4e 
The existing light theme has relatively low contrast between the text
(and other UI elements) and background (especially within code blocks).
This presents difficulties for people with reduced visual contrast
perception (common in older adults).

This patch makes changes to the default `light` theme to meet the
minimum contrast requirement of the v2.1 W3C WCAG (Web Content
Accessibility Guidelines)
https://www.w3.org/WAI/WCAG21/quickref/#contrast-minimum

The small size, and slender font used for the title text makes it hard
to read, even with the increased contrast colour scheme, so this patch
also increases the size of the title text font by 20%.

Closes rust-lang#1442
rubenmoor pushed a commit to rubenmoor/mdBook that referenced this issue Aug 5, 2022
@tim-seoss @rubenmoor
Enhance text contrast of light theme to improve accessibility.
53ec0f9 
The existing light theme has relatively low contrast between the text
(and other UI elements) and background (especially within code blocks).
This presents difficulties for people with reduced visual contrast
perception (common in older adults).

This patch makes changes to the default `light` theme to meet the
minimum contrast requirement of the v2.1 W3C WCAG (Web Content
Accessibility Guidelines)
https://www.w3.org/WAI/WCAG21/quickref/#contrast-minimum

The small size, and slender font used for the title text makes it hard
to read, even with the increased contrast colour scheme, so this patch
also increases the size of the title text font by 20%.

Closes rust-lang#1442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhance text contrast of light theme to improve accessibility. tim-seoss/mdBook
3 participants
@ehuss @endgame @tim-seoss