Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "next chapter" spacer handling. #1075

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 24, 2019

Fix "next chapter" detection in index.html when the next chapter is a spacer.

If the item in SUMMARY.md immediately after the first chapter is a spacer (---), then it was failing because that is not a real chapter.

Closes #1074

@ehuss ehuss force-pushed the fix-next-with-spacer branch from 00feef0 to 9b9d8f4 Compare October 24, 2019 18:57
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Have tested and worked as expectations.

@Dylan-DPC-zz Dylan-DPC-zz merged commit 21d8f39 into rust-lang:master Oct 25, 2019
@weihanglo
Copy link
Member

@ehuss
Do we need to release a patch version for this PR?

@ehuss
Copy link
Contributor Author

ehuss commented Oct 27, 2019

@weihanglo v0.3.3 has been released

Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error rendering "index": No title found for chapter in JSON data
3 participants