Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make new [rust] section to config and place edition under it #1163

Merged
merged 4 commits into from
Apr 21, 2020
Merged

Make new [rust] section to config and place edition under it #1163

merged 4 commits into from
Apr 21, 2020

Conversation

kngwyu
Copy link
Contributor

@kngwyu kngwyu commented Mar 9, 2020 •
edited
Loading

On #1100.
Made new top-level configuration [rust] and moved edition config under it.
cc: @kpp @ehuss

kpp
kpp approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@kpp kpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I completely forgot about that PR. Shame on me ><'

@kngwyu kngwyu force-pushed the kpp-edition2018 branch from fa78d90 to 825fbbc Compare March 9, 2020 16:06
@ehuss ehuss force-pushed the kpp-edition2018 branch from 825fbbc to aeb1184 Compare April 21, 2020 19:22
@ehuss ehuss force-pushed the kpp-edition2018 branch from aeb1184 to 28ce8f5 Compare April 21, 2020 19:26
ehuss
ehuss reviewed Apr 21, 2020
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pushed some fixes and updates.

@ehuss ehuss merged commit 712362f into rust-lang:master Apr 21, 2020
@ehuss ehuss mentioned this pull request Apr 21, 2020
Closed
@kngwyu kngwyu deleted the kpp-edition2018 branch April 24, 2020 07:45
@kngwyu
Copy link
Contributor Author

kngwyu commented Apr 24, 2020

Cool, thanks!
I'm looking forward to see edition = 2018 simplifies real playpens :)

@ehuss ehuss mentioned this pull request May 20, 2020
Merged
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
@ehuss
Merge pull request rust-lang#1163 from kngwyu/kpp-edition2018
99cf501 
 Make new [rust] section to config and  place edition under it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

@kpp kpp kpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kngwyu @ehuss @kpp @GabrielMajeri