Update toml-query to 0.10 #1210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in hopes of eventually bumping transitive dependencies to remove syn <1.0 from the dependency tree. The only dependency holding us back seems to be elasticlunr > strum_macros, which would need to be fixed upstream.
This was referenced May 5, 2020
|
Thanks for the PR! I'm planning on removing toml-query completely, though. Unfortunately removing the old syn will be difficult because mdbook uses elasticlunr and select which aren't maintained much. I think select will be particularly hard, because the newer html5ever removes some fundamental things it uses. |
|
I know there are some issues wrt feature unification for build- and regular deps but is the same for dev-dependencies (which select is) as well? If that would not be an issue, then assuming the elasticlunr-rs PR is merged and a new version is released, we just might make it. |
|
Since #1211 will supersede this PR, I'll close this. Thanks for working on making the codebase more maintainable! |
|
Oh, yea, for non-dev builds, I guess select isn't as important. |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 10, 2020
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 14, 2020
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 15, 2020
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 16, 2020
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in hopes of eventually bumping transitive dependencies to remove syn <1.0 from the dependency tree.
The only dependency holding us back seems to be elasticlunr > strum_macros, which would need to be fixed upstream.
The main goal of this PR is to remove syn <1.0 from transitive dependencies in the Rust tree.