-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip HTML nodes in SUMMARY.md #1437
Skip HTML nodes in SUMMARY.md #1437
Conversation
Thanks for the PR! It looks like the problem is a little more complex thank how I think at a minimum As for the |
- Revert changes in parse_numbered(). They were unnecessary.
@ehuss — Thanks for your feedback. I realized that my change in When I started to work on this PR, I changed Please review this PR again and let me know if you have any questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@ehuss
So we would be very happy if you release version |
@y-yu, sure! 0.4.8 should be published now. |
Thanks!👍 |
This pull request changes mdBook 0.4.x to skip any HTML node (such as HTML comment) in
SUMMARY.md
.Here is an example
SUMMARY.md
from rust-lang-ja/book-ja repository. This repository is for a Japanese translation of "The Rust Programming Language" book.(We are keeping the original English texts in HTML comments to track future updates in the original)
Without this change, mdBook 0.4.x will fail as the followings:
Note that mdBook 0.3.7 can parse the same
SUMMARY.md
without problem.