-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chinese search support #1496
chinese search support #1496
Conversation
Why is this pr not merged and there is no reply? There are many people in the Chinese community who use mdbook and can only search in English at the moment, so why hasn't this pr been merged in 10 months? Is there any reason? |
Sorry, I don't have time to review all PRs. Just a quick scan of this PR, there are a number of issues:
|
@ehuss Thanks for the reply, know the reason can be better to improve it. |
I tried it, and it seems that extra javascript should be included as additional-js. If so, then maybe we should treat the extra javascript files in another way? [output.html]
additional-js = [
"lunr.zh.js",
"lunr.stemmer.support.js",
] |
Please add language = 'zh-CN', 'zh-HK', 'zh-TW' these aliases |
Any progress to this PR? Really need Non-English Support. |
I think so too. |
Is there any progress on this pr? |
javascript From https://github.com/MihaiValentin/lunr-languages, a better option would be to just use "lunr-languages" and no longer use "elasticlunr". Until then, it may be necessary to wait for some progress to be made on #5 . A better option might be https://github.com/ajitid/fzf-for-js, a local search engine that supports Unicode, see ajitid/fzf-for-js#112 for Unicode support. |
Chinese is usually troublesome because there are no word breaks, meaning that the indexing must be done via either a heuristic to break up words or a natural language processor that understands the text and can break words. Otherwise you'd need to index all individual characters as well as all pairwise combinations at least |
Looking forward to new progress on this MR |
Are there any new developments on this issue? |
is there any progress about this issue? |
@ehuss I'd like to work on this feature request. Would creating my own fork and making a new PR be the correct way to do this? |
chinese search support.
set
language
tozh
, then you can search chinese word.