Add 'email' to list of fields where s is not a shortcut for search
#1569
Conversation
| @@ -316,7 +316,7 @@ window.search = window.search || {}; | |||
|
|
|||
| // Eventhandler for keyevents on `document` | |||
| function globalKeyHandler(e) { | |||
| if (e.altKey || e.ctrlKey || e.metaKey || e.shiftKey || e.target.type === 'textarea' || e.target.type === 'text') { return; } | |||
| if (e.altKey || e.ctrlKey || e.metaKey || e.shiftKey || e.target.type === 'textarea' || e.target.type === 'text' || e.target.type === 'email') { return; } | |||
There was a problem hiding this comment.
Instead of wack-a-mole on the on the input types, perhaps something like this would work?
!hasFocus() && /^(?:input|select|textarea)$/i.test(e.target.nodeName)
There was a problem hiding this comment.
<input type=checkbox>, radio, submit do not accept arbitrary keyboard input, and should probably allow the search shortcut.
There was a problem hiding this comment.
!hasFocus() && /^(?:input|select|textarea)$/i.test(e.target.nodeName) worked for me. I have a sign-up and login form, which otherwise I couldn't type s. When adding the above, it works perfectly fine. I would love to get this merged to avoid building myself every time.
ehuss
added
the
S-waiting-on-author
|
@daniel-vainsencher @ehuss Could we add ehuss suggestions and merge it afterward? WDYT? Update: I created a PR (#2311) with that change ehuss suggested, ready to merge (I'm running that version on my book (dedp.online). |
|
I'm going to close as I believe this will be resolved by #2311. Thanks! |
No description provided.