-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some x overflows #1617
Fix some x overflows #1617
Conversation
Thanks, I have a few questions, though: What does the Can you say more about why this uses a div wrapper? Is it a concern about Are there any concerns about using |
Thanks for the review! Looking deeper into these questions has been useful for me as a CSS non-expert.
The conditions in which this happen are when there are long cells (I stuffed some extra long text into the cell to get it to overflow a little harder) or generally more width than fits on the screen. This is what the The reason it needs to be on a wrapper div with the
I somehow missed the deprecation notice, my bad (from further googling, it was deprecated as of CSS 3). I can confirm that From putting some long stuff into a paragraph, I realized we probably should enable this everywhere on the app since it's possible to cause x overflows with body text too. I am going to do that:
Some code, overflowing without word breaking configured: |
@lf- @ehuss please take a look : I think rather than OriginalThis is without the changes in this PR As you can see this makes the whole page scroll in mobile, rather than the table (evident by the page title being off screen), which was the issue. After this PRThe issue is due to Here, to prevent overflow, it breaks every word into characters and wraps them around. With suggested changesNow with using main {
overflow-wrap: break-word;
} (table wrapper class introduced in this PR is kept as in this PR) where it scrolls the table, rather than scrolling the whole page, as evident by the page title staying in view, and the columns being scrolled. |
Oh, yea, it looks like |
@lf- Would you be willing to update this using |
Done and rebased. |
@ehuss if you missed the notif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm going to go ahead and merge, though I still have some concerns about how this might impact or break things. I can't think of any specific problems, and testing on a variety of browsers seems to be OK.
This PR fixes long inline code doing an x overflow.
There's another x-overflow on this page, where the table with the heading "punycode + encoding" also overflows slightly. I have fixed this one as well.
Spotted on
https://rust-lang.github.io/rfcs/2603-rust-symbol-name-mangling-v0.html