Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semver dev-dependency in nop-preprocessor example to 1.0 #1732

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Jan 23, 2022

The API involved in the example is the following, none of which has changed between 0.11 and 1.0.

use semver::{Version, VersionReq};

let book_version = Version::parse(&ctx.mdbook_version)?;
let version_req = VersionReq::parse(mdbook::MDBOOK_VERSION)?;
if !version_req.matches(&book_version) {

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ehuss ehuss merged commit 0ec4b69 into rust-lang:master Jan 24, 2022
@dtolnay dtolnay deleted the semver branch June 19, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants