Always open index page with serve --open
#1830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
mdbook serve --open
may land on a 404 page if the file name is changed. This is easily reproduced by runningmdbook serve --open guide
on mdBook itself, which will openhttp://localhost:3000/README.html
, which 404's thanks to theindex
preproc.Since mdBook seems to always generate an
index.html
page for the first chapter anyway, it seems that "trimming the fat" is also more correct.