Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid empty last line in editable code blocks #1836

Merged
merged 1 commit into from
Aug 11, 2022

Commits on Aug 10, 2022

  1. Trim trailing whitespace in Rust code blocks

    Before, a code block would always end with a final newline. The
    newline was added unconditionally by `hide_lines`.
    
    When the code block is syntax highlighted by highlight.js, this is not
    a problem, no empty line is added for a final trailing `\n` character.
    However, when the code block is editable and thus handled by the ACE
    editor, a trailing newline _is_ significant. I believe this issue is
    most closely described by ajaxorg/ace#2083
    in the upstream repository.
    
    The effect of the way ACE handles newlines is that a code block like
    
        <pre>
          Some code
        </pre>
    
    will create an editor with _two_ lines, not just one.
    
    By trimming trailing whitespace, we ensure that we don’t accidentally
    create more lines in the ACE editor than necessary.
    mgeisler committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    217546c View commit details
    Browse the repository at this point in the history