Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrades to MathJax version 3 and supports setting different configuration files (defaults to 'tex-mml-chtml'). #2285

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HouJP
Copy link

@HouJP HouJP commented Jan 6, 2024

Introduction

This PR is used to upgrade to MathJax version 3 and supports setting different configuration files (defaults to 'tex-mml-chtml).

It is inspired by the issue: mdBook doesn't support mathcal symbols.

Closes #2284.

Background

This PR can fix a bug hidden in MathJax v2 introduced here.

… configuration files (defaults to 'tex-mml-chtml').
@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Jan 6, 2024
@ehuss
Copy link
Contributor

ehuss commented Jan 6, 2024

Thanks for the PR! I believe #1918 is already open to address this. Can you give it a try and see how it works for you?

@HouJP
Copy link
Author

HouJP commented Jan 6, 2024

Thanks @ehuss!

I took a quick look and I think it will also solve the problem.

The advantage of that PR is that it's more flexible (e.g., local js), but its disadvantages are

  1. It requires larger changes to the configuration compared to this PR.
  2. It's NOT compatible with existing configs.

The advantages of this PR are

  1. This is a tiny change.
  2. It is compatible with previous configs.

I respect the owners' / reviewers' decision. Please feel free to let me know if you prefer to withdraw this PR.

@expikr
Copy link
Contributor

expikr commented Jan 15, 2024

I prefer this PR because it makes #2069 much easier

@ehuss ehuss added the A-MathJax Area: MathJax label Feb 25, 2024
@edwardzcn-decade
Copy link

Can @ehuss review this PR again? I meet the same problem in #2284 and I think it is common when using mdbook in macOS 13 Ventura and above (for me it is macOS 15) because Apple shipped the fonts which used by mathjax render v2 and left some mismatches since macOS 13.

Now your mathjax test markdown does not display italics properly on most Apple computers, and differs greatly from the schematic #2070. Also using mathcalsymbols causes formulas to not show up at all (Mathematical Calligraphic Font mismatch).

This PR just upgrade to MathJax v3 with almost the same configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-MathJax Area: MathJax S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mdBook doesn't support mathcal symbols
5 participants