Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gate few deps only used in bin by cli feature #2410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Jul 2, 2024

This adds cli feature (added to default list to prevent possible break) which gates deps used only by mdbook bin. This technically breaks users of bin with default-features = false, are they exist?

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Jul 2, 2024
@ehuss
Copy link
Contributor

ehuss commented Jul 2, 2024

Unfortunately we won't be able to make a change like this because it would break cargo install --no-default-features.

The main change in the 0.5 release is intended to fix this. I really want to get that rolling soon, it's just been hard to make time.

@klensy
Copy link
Contributor Author

klensy commented Jul 2, 2024

Looking at 0.5 milestone (https://github.com/rust-lang/mdBook/milestone/11) and don't see similar change, is there list with planned breaking changes somewhere else?

@klensy
Copy link
Contributor Author

klensy commented Jul 2, 2024

Something like #1937, which is not labeled :-(

@ehuss
Copy link
Contributor

ehuss commented Jul 2, 2024

I don't think there is a list besides the milestone. The primary thing is to split it into multiple packages, and do some API cleanup to fix backwards-compatibility issues to make it easier to update things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants