Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatic dark mode #2441

Closed
wants to merge 1 commit into from
Closed

Fix automatic dark mode #2441

wants to merge 1 commit into from

Conversation

atjn
Copy link

@atjn atjn commented Sep 21, 2024

Automatic dark mode (in CSS) was implemented in #1069, then broken in #1641 because it moved the no-js class to a different element. This PR restores the functionality. It also implements #2134 properly.

I also noticed that the original implementation depends on the light class to be set, which it is not if a different default theme has been chosen. I have also fixed this.

Closes #2440

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Sep 21, 2024
@ehuss
Copy link
Contributor

ehuss commented Nov 2, 2024

I'm going to close as I believe this will be resolved by #2454. Thanks, though!

@ehuss ehuss closed this Nov 2, 2024
@atjn atjn deleted the dark-fix branch November 9, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement auto dark mode in CSS
3 participants