Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendlier errors from build.rs and support for Windows stylus build #295

Merged
merged 3 commits into from
May 22, 2017

Conversation

budziq
Copy link
Contributor

@budziq budziq commented May 22, 2017

cargo build --features=regenerate-css should now have nicer errors and work on windows

It is written mostly to solve: https://github.com/azerupi/mdBook/issues/293
but also fixes: https://github.com/azerupi/mdBook/issues/294

Please note that I have very little Rust experience so I would be very glad for critical review.
Build.rs has become quite wordy and error-chain was added as build-dependency which is quite hevyweight for what the script does.

budziq added 3 commits May 22, 2017 04:25
Added error-chain as build-dependency
also added static lifetime to str constants as these were failing on nightly windows
@azerupi azerupi merged commit 35ef317 into rust-lang:master May 22, 2017
@azerupi
Copy link
Contributor

azerupi commented May 22, 2017

Thank you!
Looks really good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generating css from stylus fails on Windows
2 participants