Write preprocessed content to file before testing with rustdoc #891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than writing the unpreprocessed content to the file for rustdoc to test with.
Fixes #855.
I was trying to figure out whether the current behavior was intentional or not, and if I might be breaking anything with this change, but I think the fix I have here is what was intended-- my first hint was this comment that described what I had hoped was happening but that wasn't what was actually happening.
As of this commit, it seems like the behavior I was hoping for was happening and was intended ("now
mdbook test
does full link expansion to temp file prior to running" in the commit message), but this line got lost in refactoring and the preprocessors were being run but this line read the unprocessed file from disk again and gave that content to rustdoc :(If this fails CI I will fix it tomorrow ❤️