Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add event time column to summarize results #109

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

andjo403
Copy link
Contributor

name it only time for now feel that "incl. time" need more description then only having time and self-time. but feel that the "% of total time" get unclear now that we have time and self-time

closes #107

@wesleywiser wesleywiser self-assigned this Jan 15, 2020
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@wesleywiser wesleywiser merged commit 69f1f2e into rust-lang:master Jan 15, 2020
@andjo403 andjo403 deleted the summarize_time branch January 15, 2020 10:12
@michaelwoerister
Copy link
Member

Nice, thanks @andjo403!

One thing I'm wondering? How does this handle recursive invocations like:

       <---A--->
   <------B------>
<---------A--------->

How should it handle cases like this? Always only count the bottom-most stack element?

@andjo403
Copy link
Contributor Author

andjo403 commented Jan 15, 2020

as it is now it will count the time for both events in the example see the test https://github.com/rust-lang/measureme/pull/109/files#diff-98cefccab6f8905ece90aaf3c2cb1ea4R479 .
I think that is correct at least that is what I wanted the last time when I want to know how mush time is spent in this event. and feel that it will be strange if the result differs against if it was 3 diffrent events in the stack.

@michaelwoerister
Copy link
Member

I think an argument can be made for either way of counting. I think I'm fine with the way it's done here though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "incl. time" column to summarize and perf.rlo
3 participants