Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to invocation count for blocked events #148

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

andjo403
Copy link
Contributor

@andjo403 andjo403 commented Dec 6, 2020

as the time for blocked events is increased think that also the invocation count shall be increased.

was confused when looking at the result from rust-lang/rust#79706 where parallell compiler is tested,
some queries was taking long time when running in parallell so was looking in the query after the problem as the invocation count was 1, but in many cases the problem was that the same query was executed in multiple threads at the same time resulting in blocked query events.

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@wesleywiser wesleywiser merged commit 16688a5 into rust-lang:master Dec 14, 2020
@andjo403 andjo403 deleted the inc_invocation_counter branch February 28, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants