Allow recording interval event wthout drop guard #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to record events when the `Profiler` and the `TimingGuard` would need to be stored different structs.
bjorn3
reviewed
May 2, 2021
| thread_id: timing.thread_id, | ||
| start_count: timing.start_count, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Would
let start_count = profiler.counter.since_start();
// some work
let raw_event = RawEvent::new_interval(
event_kind,
event_id,
thread_id,
start_count,
profiler.counter.since_start(),
);
profiler.record_raw_event(&raw_event);work if you make profiler.counter.since_start() public? That is what the drop impl of TimingGuard does.
There was a problem hiding this comment.
It would, but I think this API is more consistent with the existing one (hiding the underlying counter). I don't have a strong opinion, though.
wesleywiser
reviewed
May 4, 2021
|
@wesleywiser I've addressed your comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to record events when the
Profilerand theTimingGuardwould need to be stored different structs.