Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Workflow for publishing measureme #221

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

wesleywiser
Copy link
Member

No description provided.

@michaelwoerister
Copy link
Member

Thanks, Wesley!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 11, 2024

📌 Commit 3df9bb3 has been approved by michaelwoerister

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 11, 2024

⌛ Testing commit 3df9bb3 with merge ebb24d8...

@bors
Copy link
Contributor

bors commented Jan 11, 2024

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing ebb24d8 to master...

@bors bors merged commit ebb24d8 into master Jan 11, 2024
6 checks passed
name: Publish to crates.io
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it might not do want we intend. IIUC, actions/checkout@master means that this will use the master branch version actions/checkout, not that it will checkout measureme's master branch. We probably want something like actions/checkout@v4, right? Ideally, we'd checkout the tag that was created for the release that triggered this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we'd checkout the tag that was created for the release that triggered this.

OK, that seems to be the default behavior:
https://stackoverflow.com/questions/71663711/how-to-get-branch-name-which-triggered-a-github-action-workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants