Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use workspace inheritance as much as possible #228

Merged
merged 9 commits into from
May 28, 2024
Merged

Use workspace inheritance as much as possible #228

merged 9 commits into from
May 28, 2024

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented May 27, 2024 •
edited
Loading

This is a follow-up of #227:

  • Remove version_checker, which is no longer used.
  • Add missing documentations and Cargo.toml metadata fields
  • Leverage Cargo workspace inheritance.

This is best reviewed commit-by-commit.

weihanglo added 7 commits May 27, 2024 11:41
@weihanglo
chore: remove redundant fields from manifest
f0afc5a 
See:

* https://doc.rust-lang.org/nightly/cargo/reference/manifest.html#the-documentation-field
* https://doc.rust-lang.org/nightly/cargo/reference/manifest.html#the-homepage-field
* https://doc.rust-lang.org/nightly/cargo/reference/manifest.html#the-badges-section
@weihanglo
chore: inherit workspace.{version,edition}
a7a8300 
Looks like the version of each member is bumped all together.
@weihanglo
chore: version_check is no longer used
18cf8de 
No longer used since migration to GitHub Actions.
Also, we leverage workspace inheritance to enforce version consistency.
@weihanglo
chore: inherit workspace.repository
a17230a
@weihanglo
chore: inherit workspace.authors
b47822f 
Some packages were missing authors fields, or had only single author,
though I guess it's fine making both Wesley and Michael as authors :)
@weihanglo
chore: sort dependencies sections
2172103
@weihanglo
chore: inherit workspace.dependencies
f2e2d3f
@weihanglo weihanglo mentioned this pull request May 27, 2024
Merged
michaelwoerister
michaelwoerister reviewed May 28, 2024
View reviewed changes
README.md Outdated

### analyzeme

`mmview` is for printing the event data generated by `measureme`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

analyzeme is a library with common functionality for measureme tools

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks!

@michaelwoerister
Copy link
Member

This looks great, thanks @weihanglo!

@michaelwoerister michaelwoerister self-assigned this May 28, 2024
@weihanglo weihanglo force-pushed the workspace-inherit branch from d710343 to d3947d8 Compare May 28, 2024 12:43
@michaelwoerister michaelwoerister merged commit 9783098 into rust-lang:master May 28, 2024
4 checks passed
@weihanglo weihanglo deleted the workspace-inherit branch May 28, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelwoerister michaelwoerister michaelwoerister approved these changes

Assignees

@michaelwoerister michaelwoerister

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weihanglo @michaelwoerister