Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use complete events in crox #59

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

andjo403
Copy link
Contributor

to reduce the size of the generated json file
fixes #47

to reduce the size of the generated json file
fixes rust-lang#47
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I'm seeing a reduction on the regex crate's profiling data from 35.6mb to 19.4mb which is very good.

@wesleywiser wesleywiser merged commit d9a055d into rust-lang:master Sep 30, 2019
@andjo403
Copy link
Contributor Author

andjo403 commented Oct 1, 2019

@wesleywiser you hade made it very easy to do with the iterator.
the crate that I looked at when I wanted this was script from servo where the file went from 1.4 GB to 0.7 GB and that was enough to get chrome to show the file after 5 min and using 6 GB memory :)

@andjo403 andjo403 deleted the complete_events branch October 1, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce Chrome profiler file size by using Complete events
2 participants