add option to crox to filter out short events #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleywiser
reviewed
Sep 30, 2019
There was a problem hiding this comment.
The code looks fine to me but I wonder if milliseconds are not granular enough. Most queries complete in less than 1 ms so passing --filter-duration-ms=1 causes most of the events to be omitted from the file.
I wonder perhaps if this flag should be in microseconds?
add possibility to reduce the json file due to some files is to large to show in the browser. minimum_duration filter out all events that is shorter than specified duration
andjo403
force-pushed
the
duration_filter
branch
from
1411b56 to
389c484
Compare
|
changed to microseconds was I that not thought last night |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some files is to large to show in the browser
filter_duration_ms filter out all events that is shorter than specified limit