Skip to content

Commit

Permalink
add comment mentioning alternative approach
Browse files Browse the repository at this point in the history
  • Loading branch information
RalfJung committed Sep 17, 2020
1 parent db067f4 commit ae859c3
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions cargo-miri/bin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,11 @@ fn phase_cargo_miri(mut args: env::Args) {
setup(subcommand);

// Invoke actual cargo for the job, but with different flags.
// We re-use `cargo test` and `cargo run`, which makes target and binary handling very easy but
// requires some extra work to make the build check-only (see all the `--emit` hacks below).
// <https://github.com/rust-lang/miri/pull/1540#issuecomment-693553191> describes an alternative
// approach that uses `cargo check`, making that part easier but target and binary handling
// harder.
let miri_path = std::env::current_exe().expect("current executable path invalid");
let cargo_cmd = match subcommand {
MiriCommand::Test => "test",
Expand Down

0 comments on commit ae859c3

Please sign in to comment.