-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate -Zmiri-allow-uninit-numbers? #2187
Labels
Comments
RalfJung
added
A-interpreter
Area: affects the core interpreter
C-cleanup
Category: cleaning up our code
labels
Jun 5, 2022
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this issue
Aug 26, 2022
…-obk interpret: remove support for uninitialized scalars With Miri no longer supporting `-Zmiri-allow-uninit-numbers`, we no longer need to support storing uninit data in a `Scalar`. We anyway already only use this representation for types with *initialized* `Scalar` layout (and we have to, due to partial initialization), so let's get rid of the `ScalarMaybeUninit` type entirely. I tried to stage this into meaningful commits, but the one that changes `read_immediate` to always trigger UB on uninit is the largest chunk of the PR and I don't see how it could be subdivided. Fixes rust-lang/miri#2187 r? ``@oli-obk``
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this issue
Aug 26, 2022
…-obk interpret: remove support for uninitialized scalars With Miri no longer supporting `-Zmiri-allow-uninit-numbers`, we no longer need to support storing uninit data in a `Scalar`. We anyway already only use this representation for types with *initialized* `Scalar` layout (and we have to, due to partial initialization), so let's get rid of the `ScalarMaybeUninit` type entirely. I tried to stage this into meaningful commits, but the one that changes `read_immediate` to always trigger UB on uninit is the largest chunk of the PR and I don't see how it could be subdivided. Fixes rust-lang/miri#2187 r? ```@oli-obk```
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this issue
Aug 26, 2022
…-obk interpret: remove support for uninitialized scalars With Miri no longer supporting `-Zmiri-allow-uninit-numbers`, we no longer need to support storing uninit data in a `Scalar`. We anyway already only use this representation for types with *initialized* `Scalar` layout (and we have to, due to partial initialization), so let's get rid of the `ScalarMaybeUninit` type entirely. I tried to stage this into meaningful commits, but the one that changes `read_immediate` to always trigger UB on uninit is the largest chunk of the PR and I don't see how it could be subdivided. Fixes rust-lang/miri#2187 r? ````@oli-obk````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I would love to deprecate the -Zmiri-allow-uninit-numbers flag some time later this year. Removing that flag would allow us to do some significant cleanup in the interpreter -- we could entirely remove the
ScalarMaybeUninit
type!The text was updated successfully, but these errors were encountered: