-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICE with validation disabled #754
Labels
Comments
We could setup a weekly cronjob for all flags On 31 May 2019 15:59, Ralf Jung <notifications@github.com> wrote:The following test passes normally but ICEs when validation gets disabled:
use std::cell::*;
fn main() {
let cell: RefCell<[i32; 3]> = RefCell::new([1, 2, 3]);
{
let mut cellref: RefMut<'_, [i32; 3]> = cell.borrow_mut();
cellref[0] = 4;
let mut coerced: RefMut<'_, [i32]> = cellref;
coerced[2] = 5;
}
{
let comp: &mut [i32] = &mut [4, 2, 5];
let cellref: Ref<'_, [i32; 3]> = cell.borrow();
assert_eq!(&*cellref, comp);
let coerced: Ref<'_, [i32]> = cellref;
assert_eq!(&*coerced, comp);
}
}
We don't test -Zmiri-disable-validation very much. But we also cannot test every flag...
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.
|
I might have CI time budget to run at least some of the libstd test suites without validation on #754. |
Centril
added a commit
to Centril/rust
that referenced
this issue
Jun 4, 2019
miri unsizing: fix projecting into a field of an operand I don't know why this open-coded an operand field projection. Probably this code predates one or more of my refactorings. Fixes rust-lang/miri#754 r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this issue
Jun 4, 2019
miri unsizing: fix projecting into a field of an operand I don't know why this open-coded an operand field projection. Probably this code predates one or more of my refactorings. Fixes rust-lang/miri#754 r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this issue
Jun 4, 2019
miri unsizing: fix projecting into a field of an operand I don't know why this open-coded an operand field projection. Probably this code predates one or more of my refactorings. Fixes rust-lang/miri#754 r? @oli-obk
RalfJung
added
A-interpreter
Area: affects the core interpreter
C-bug
Category: This is a bug.
labels
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The following test passes normally but ICEs when validation gets disabled:
We don't test
-Zmiri-disable-validation
very much. But we also cannot test every flag...The text was updated successfully, but these errors were encountered: