-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a scheme to find the place where an id was destroyed #1080
Conversation
☔ The latest upstream changes (presumably #1083) made this pull request unmergeable. Please resolve the merge conflicts. |
What a hack! But it's not like I have a better idea that's even remotely as simple, so, the basic approach seems fine to me. |
761a6cc
to
d6f168a
Compare
Uh... that's really nasty. And you're aborting in the middle of a Stacked Borrows operation. I don't think it is a good idea to go on executing -- as you said, that's basically a corrupt state, so any follow-up errors might be completely bogus. I prefer your first scheme. |
d6f168a
to
817f415
Compare
LGTM! r=me with the open suggestion applied. |
Co-Authored-By: Ralf Jung <post@ralfj.de>
@bors r=RalfJung |
📌 Commit 8d409a7 has been approved by |
Add a scheme to find the place where an id was destroyed cc #974 I'm not too happy with it, but since stacked borrows don't have access to the current call stack, I can't just report a warning as per #797 We could add some global mutex that we can throw strings at and `step` will clear out that mutex and report warnings before moving the `statement_id` or the `block_id`, not sure how well that would work. For now I think this is sufficient
☀️ Test successful - checks-travis, status-appveyor |
cc #974
I'm not too happy with it, but since stacked borrows don't have access to the current call stack, I can't just report a warning as per #797
We could add some global mutex that we can throw strings at and
step
will clear out that mutex and report warnings before moving thestatement_id
or theblock_id
, not sure how well that would work. For now I think this is sufficient