Add a scheme to find the place where an id was destroyed #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Nov 28, 2019
|
☔ The latest upstream changes (presumably #1083) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJung
reviewed
Nov 29, 2019
RalfJung
reviewed
Nov 29, 2019
RalfJung
reviewed
Nov 29, 2019
RalfJung
reviewed
Nov 29, 2019
|
What a hack! But it's not like I have a better idea that's even remotely as simple, so, the basic approach seems fine to me. |
oli-obk
force-pushed
the
stacked_borrow_tracing
branch
from
761a6cc
to
d6f168a
Compare
RalfJung
reviewed
Dec 8, 2019
|
Uh... that's really nasty. And you're aborting in the middle of a Stacked Borrows operation. I don't think it is a good idea to go on executing -- as you said, that's basically a corrupt state, so any follow-up errors might be completely bogus. I prefer your first scheme. |
oli-obk
force-pushed
the
stacked_borrow_tracing
branch
from
d6f168a
to
817f415
Compare
|
LGTM! r=me with the open suggestion applied. |
Co-Authored-By: Ralf Jung <post@ralfj.de>
|
@bors r=RalfJung |
|
📌 Commit 8d409a7 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 10, 2019
Add a scheme to find the place where an id was destroyed cc #974 I'm not too happy with it, but since stacked borrows don't have access to the current call stack, I can't just report a warning as per #797 We could add some global mutex that we can throw strings at and `step` will clear out that mutex and report warnings before moving the `statement_id` or the `block_id`, not sure how well that would work. For now I think this is sufficient
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #974
I'm not too happy with it, but since stacked borrows don't have access to the current call stack, I can't just report a warning as per #797
We could add some global mutex that we can throw strings at and
stepwill clear out that mutex and report warnings before moving thestatement_idor theblock_id, not sure how well that would work. For now I think this is sufficient